Replace ReferenceLoopHandling with direct method call #3618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the ReferenceLoopHandling property manipulation in FieldsJsonConverter that is used to circumvent Json.NET's reference loop detection when Fields contains only a single Field, with a direct call to the serialization method on FieldJsonConverter for each Field. Fixes #3617
codebrain
approved these changes
Mar 21, 2019
Contributor
codebrain
left a comment
codebrain
left a comment
There was a problem hiding this comment.
LGTM - makes sense to push this to the serialiser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the ReferenceLoopHandling property manipulation
in FieldsJsonConverter that is used to circumvent Json.NET's reference
loop detection when Fields contains only a single Field, with a direct
call to the serialization method on FieldJsonConverter for each Field.
Fixes #3617